nsqadmin: eslint fixes #1080
Merged
nsqadmin: eslint fixes #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
commented
Sep 4, 2018
| if (key === 'gc_runs') { | ||
| target = 'movingAverage(' + target + ',45)'; | ||
| } | ||
| var fullKey = formatStatsdKey(metricType(key), target); | ||
| targets.push(target); |
There was a problem hiding this comment.
e.g. this one (using target not fullKey)
mreiferson
commented
Sep 4, 2018
| @@ -88,11 +91,10 @@ var genTargets = function(typ, node, ns1, ns2, key) { | |||
| if (node === '*') { | |||
| t = 'averageSeries(' + t + ')'; | |||
| } | |||
| var fullKey = formatStatsdKey(metricType(key), t); | |||
| return 'scale(' + t + ',0.000001)'; | |||
There was a problem hiding this comment.
and this one (using t not fullKey)
ploxiln
approved these changes
Sep 5, 2018
There was a problem hiding this comment.
This all looks good.
Checking this out locally and using eslint v5.2.0 I still get these things, which just need to be ignored somehow:
$ eslint static/js/
/Users/pierce/go/src/github.com/nsqio/nsq/nsqadmin/static/js/app_state.js
7:24 warning 'VERSION' is not defined no-undef
8:29 warning 'GRAPHITE_URL' is not defined no-undef
9:30 warning 'GRAPH_ENABLED' is not defined no-undef
10:32 warning 'STATSD_INTERVAL' is not defined no-undef
11:38 warning 'STATSD_COUNTER_FORMAT' is not defined no-undef
12:36 warning 'STATSD_GAUGE_FORMAT' is not defined no-undef
13:30 warning 'STATSD_PREFIX' is not defined no-undef
14:27 warning 'NSQLOOKUPD' is not defined no-undef
16:25 warning 'IS_ADMIN' is not defined no-undef
17:26 warning 'BASE_PATH' is not defined no-undef
/Users/pierce/go/src/github.com/nsqio/nsq/nsqadmin/static/js/lib/ajax_setup.js
7:24 warning 'USER_AGENT' is not defined no-undef
✖ 11 problems (0 errors, 11 warnings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels like a good time to land this after #856
Some of the fixes in the Handlebars helpers for graphite look like they'll fix real bugs :)