Makefile: replace GOFLAGS with BLDFLAGS

[ploxiln]

new in go-1.11 GOFLAGS is an environment variable used by go build
with conflicting escaping compared to how we used it in the Makefile

recently discovered this when trying to build a linux package with go-1.11 (it definitely worked with go-1.10)

[pierce@plo-pro nsq]$ go version
go version go1.11 darwin/amd64
[pierce@plo-pro nsq]$ go env | grep GOFLAGS
GOFLAGS=""
[pierce@plo-pro nsq]$ make clean
rm -fr build
[pierce@plo-pro nsq]$ make GOFLAGS='-ldflags="-s -w"' build/nsqd
go build -ldflags="-s -w" -o build/nsqd ./apps/nsqd
go: parsing $GOFLAGS: unknown flag -w"
make: *** [build/nsqd] Error 1
[pierce@plo-pro nsq]$ make GOFLAGS='-ldflags=-s -w' build/nsqd
go build -ldflags=-s -w -o build/nsqd ./apps/nsqd
go: parsing $GOFLAGS: unknown flag -w
make: *** [build/nsqd] Error 1

cc @mreiferson

[mreiferson]

thanks, is this documented anywhere?

[ploxiln]

I don't think we mention this GOFLAGS we had in our Makefile in any nsq docs, and I can't find mention of GOFLAGS in https://golang.org/doc/go1.11 nor in a google search.

[ploxiln]

I guess there's this https://golang.org/pkg/cmd/go/internal/base/#GOFLAGS

[ploxiln]

[pierce@plo-pro av-infra]$ go version
go version go1.10.3 darwin/amd64
[pierce@plo-pro av-infra]$ go env | grep GOFLAGS
[pierce@plo-pro av-infra]$

[mreiferson]

I meant the Go docs, np.

I think I follow, we're trying to avoid clobbering a built-in Go environment variable, not that BLDFLAGS has any meaning on its own?

[ploxiln]

Correct, I just made up BLDFLAGS to hopefully not conflict with anything in go.

(I was also surprised that make put the variable GOFLAGS in the environment, I thought it would be treated more like a plain shell script variable, I guess I should have know better :P)

[mreiferson]

Shall we expect an update to your (in)famous blog post? 😬