Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update to use Go modules #1115

Merged
merged 14 commits into from
Jan 2, 2019
Merged

*: update to use Go modules #1115

merged 14 commits into from
Jan 2, 2019

Conversation

mreiferson
Copy link
Member

The Go dependency management saga continues — in part III we introduce go.mod!

Addresses #1114

@mreiferson mreiferson mentioned this pull request Dec 27, 2018
Closed
@mreiferson mreiferson requested a review from ploxiln December 29, 2018 17:32
ploxiln
ploxiln approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@ploxiln ploxiln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. I appreciate that dep is still supported for now.

@mreiferson mreiferson merged commit 141597d into nsqio:master Jan 2, 2019
@mreiferson mreiferson deleted the gomod branch January 2, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ploxiln ploxiln ploxiln approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreiferson @ploxiln