Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqlookupd: fix orphaned ephemeral topics in registration DB #1116

Merged
merged 1 commit into from
Jan 3, 2019
Merged

nsqlookupd: fix orphaned ephemeral topics in registration DB #1116

merged 1 commit into from
Jan 3, 2019

Conversation

mreiferson
Copy link
Member

Turns out we just weren't cleaning things up properly in nsqlookupd.

Fixes #1101.

@mreiferson mreiferson added the bug label Jan 2, 2019
@mreiferson mreiferson requested a review from ploxiln January 2, 2019 22:43
@mreiferson mreiferson mentioned this pull request Jan 2, 2019
Closed
jehiah
jehiah approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@jehiah jehiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from my quick review

@mreiferson mreiferson merged commit 14e0a37 into nsqio:master Jan 3, 2019
@mreiferson mreiferson deleted the orphan-ephemeral-topics branch January 3, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehiah jehiah jehiah approved these changes

@ploxiln ploxiln Awaiting requested review from ploxiln

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreiferson @jehiah