nsq_to_file: revert gzip behavior change #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mreiferson thoughts? |
This reverts commit 5ea1012. also some further tweaks due to FileLogger refactor
ploxiln
force-pushed
the
to_file_gzip_multi
branch
from
5df7725 to
6b4b720
Compare
|
As a followup, I feel like we should comment the reason why we sync the way we do in that function? WDYT @ploxiln? |
|
sure, will add in #1123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we're all swayed by @jehiah's arguments in #1117 (comment) I opened this easy PR.
I'll squash before merge - I left the mechanical revert separate from additional tweaks needed due to the rest of the refactor, for possibly easier review.
cc @mreiferson