nsqadmin: confirm actions #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for that. |
|
+1, bonus +1 for use of 'crash whole civilisation' (it's true.) |
| @@ -275,7 +276,7 @@ func lookupHandler(w http.ResponseWriter, req *http.Request) { | |||
| } | |||
|
|
|||
| func createTopicChannelHandler(w http.ResponseWriter, req *http.Request) { | |||
| reqParams, err := util.NewReqParams(req) | |||
| reqParams, err := util.NewBodyReqParams(req) | |||
There was a problem hiding this comment.
let's switch to explicitly require POST, and to use req.FormValue(key) so this handles multipart forms as well.
|
updates to change parsing of post body look good. Please squash. |
|
rebased/squashed |
absolute8511
added a commit
to absolute8511/nsq
that referenced
this pull request
Jan 12, 2023
log topic name for channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for a variety of reasons this is a good idea :)