nsqadmin: update run-time js deps, fix channel delete #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
bump_handlebars
branch
from
962b532 to
e884588
Compare
handlebars 4.0.11 -> 4.2.1 backbone 1.2.3 -> 1.4.0 bootstrap 3.3.6 -> 3.4.1 jquery 3.3.1 -> 3.4.1 moment 2.11.2 -> 2.24.0 left gulp and browserify related build-tool deps alone for now
I don't fully understand "this" scope, but this change seems to fix the delete button for both firefox and chrome.
The Content-Type of the source-map file is not supposed to matter. But, if Content-Encoding is gzip, and Content-Type is x-gzip, then Firefox does not decompress the response before trying to decode json, and fails to load the source map for the debugger, complaining: "unexpected character at line 1 column 1 of the JSON data". With a proper Content-Type, Firefox decompresses and understands. (Chrome works either way.)
ploxiln
force-pushed
the
bump_handlebars
branch
from
ef8ad18 to
4d384b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1188
and also another little thing I ran into
cc @jehiah @mreiferson