nsqlookupd: synchronize goroutines to avoid t.Log data races #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjsto
changed the title
ploxiln
reviewed
Sep 19, 2019
ploxiln
reviewed
Sep 19, 2019
benjsto
force-pushed
the
benjsto/go-1-12-tests
branch
from
e83b1e6 to
1837898
Compare
ploxiln
reviewed
Sep 19, 2019
|
worth noting: nsqd also uses I think this is good. Please squash commits together before merge. |
benjsto
force-pushed
the
benjsto/go-1-12-tests
branch
from
8f7352e to
dbc2b9c
Compare
|
I assumed something like that was going on for nsqd's use of TCPServer but hadn't dug into it. Thanks for clarifying. Thanks for your help on this - I've removed that unnecessary Delete and squashed and rebased. |
benjsto
force-pushed
the
benjsto/go-1-12-tests
branch
from
dbc2b9c to
61de19e
Compare
ploxiln
added a commit
to ploxiln/nsq
that referenced
this pull request
Oct 15, 2019
Consumer connections are closed when topics are closed, but tcp-protocol publish connections are not, so add tcpServer.CloseAll(). problem introduced by nsqio#1190
ploxiln
added a commit
to ploxiln/nsq
that referenced
this pull request
Oct 15, 2019
Consumer connections are closed when topics are closed, but tcp-protocol publish connections are not, so add tcpServer.CloseAll(). problem introduced by nsqio#1190
suhailpatel
added a commit
to monzo/nsq
that referenced
this pull request
Oct 7, 2021
This commit picks nsqio#1190 and backports it to this version of NSQ to avoid data races in t.Log flagged up by the race detector
suhailpatel
added a commit
to monzo/nsq
that referenced
this pull request
Dec 16, 2021
This commit picks nsqio#1190 and backports it to this version of NSQ to avoid data races in t.Log flagged up by the race detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the data race seen here: #1157 by providing a mechanism for all handler goroutines in
nsqlookupdto exit before tests finish.I'm obviously new here so let me know if there are better/simpler ways to accomplish this.