tests: update travis-ci go versions - up to 1.13 #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
test_new_golang
branch
from
8a1ac96 to
6aee2e3
Compare
jehiah
approved these changes
Dec 2, 2019
| @@ -3,6 +3,8 @@ go: | |||
| - 1.9.x | |||
| - 1.10.x | |||
| - 1.11.x | |||
| - 1.12.x | |||
There was a problem hiding this comment.
Do we want to switch to just support the last 2 releases here and in go-nsq? (i.e. 1.12.x and 1.13.x)
There was a problem hiding this comment.
I like supporting old versions when it is easy. I was thinking about dropping the versions in the middle though (assuming that if 1.9 works and 1.12 works then 1.10 and 1.11 very likely are fine).
There was a problem hiding this comment.
👍 Can you capture that as a comment in this file along the lines of "Tests are run against the two most recent Go versions, and a minimum supported version (when different)"
ploxiln
force-pushed
the
test_new_golang
branch
from
6aee2e3 to
6115412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.