nsqadmin: new flag --dev-static-dir instead of debug build tag #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
nsqadmin_assets_debug_flag
branch
from
a84a4ad to
9068ea6
Compare
mreiferson
reviewed
Sep 11, 2021
| ) | ||
|
|
||
| func staticAsset(name string) ([]byte, error) { | ||
| path := path.Join("../../nsqadmin/static/build", name) |
There was a problem hiding this comment.
I think the ugliness and problems likely resulting from this hard-coded path justify this change
There was a problem hiding this comment.
indeed, this was the motivation :)
thanks
avoid hard-coded ../../nsqadmin/static/build in debug build, more flexible and obvious this way
ploxiln
force-pushed
the
nsqadmin_assets_debug_flag
branch
from
9068ea6 to
2e99e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more flexible, perhaps simpler
it's subjective, let me know what you think :)