Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete validTopicChannelNameRegex useless escape characters #1428

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

sjatsh
Copy link
Contributor

@sjatsh sjatsh commented Oct 19, 2022

No description provided.

Copy link
Member

@ploxiln ploxiln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, inside a character class ([]), . does not need to be escaped

@ploxiln
Copy link
Member

ploxiln commented Oct 24, 2022

We could probably afford a few trivial test cases for this regex, just to assure everyone ... but anyway I whipped up a minimal sandbox demo https://go.dev/play/p/WI5A9QGHMwM?v=goprev

@ploxiln ploxiln merged commit 9bd7d8b into nsqio:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants