-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use absolute imports, so nsq is go gettable #167
Conversation
Looks like the travis build is failing. You'll need to add the rest of the |
Currently, when travis-ci'ing go repositories, we set GOPATH and copy the code to it. Would it be good for you or do you prefer that I just add Here is an example: |
It probably makes sense to build the correct $GOPATH tree and copy code over to it. Also, this section https://github.com/bitly/nsq/blob/master/INSTALLING.md#compiling needs updating. It should probably just read: Use
The Go package for building clients is |
Done, please take another look :-) Here is the working build: https://travis-ci.org/fsouza/nsq/builds/5742716. |
**assert** https://github.com/bmizerany/assert | ||
|
||
$ go get github.com/bmizerany/assert | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually like giving a shoutout to these other projects here 😄. Perhaps just remove the specific go get
references for these two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looks like I'm stupid. Running go get github.com/bitly/nsq/...
won't download assert because it's used only in tests.
Sorry about that, will fix.
Please take another look. |
Thanks @fsouza, looks good. Want to add yourself to contributors on the README? And finally, we like to rebase/squash down to 1 (occasionally more) logical commits before we merge... would you mind doing that? |
Done, I reduced it to a single commit. I've also ran |
LGTM thanks again! |
use absolute imports, so nsq is go gettable
Fixes issue #166.