nsqadmin: better nodes list info #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RFR @jehiah |
| @@ -7,6 +7,7 @@ | |||
| <div class="row-fluid"><div class="span12"> | |||
| <table class="table table-bordered"> | |||
| <tr> | |||
| <th>Remote Addresses</th> | |||
There was a problem hiding this comment.
Let's call this "lookupd connections", and display it as a count of connections. There should then be some sort of option to display the detailed actual connection info, and a prompt in the IsAmbiguous case where the number != expected lookupd's.
| @@ -12,16 +12,23 @@ | |||
| <th>TCP Port</th> | |||
| <th>HTTP Port</th> | |||
| <th>Version</th> | |||
| <th>Lookupd Conns.</th> | |||
There was a problem hiding this comment.
This column should be conditional in the case where nsqadmin is running against nsqd's directly and not nsqlookupd's
|
LGTM aside from comments |
|
updated |
* show the remote addresses over which the producer is connected to lookupd
jehiah
added a commit
that referenced
this pull request
May 13, 2013
nsqadmin: better nodes list info
arussellsaw
pushed a commit
to arussellsaw/nsq
that referenced
this pull request
Mar 5, 2018
- closes nsqio#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was an issue where an NSQ installation was sending
nsqlookupdduplicatebroadcast_addressdata andnsqadminwasn't very helpful in discovering this.this change adds
remote_addressinfo to the/nodeslist so that we can use that for uniqueness.cc @devdazed @jehiah