nsq*: log HTTP requests #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
force-pushed
the
http_logs_610
branch
4 times, most recently
from
963395f to
8a9f047
Compare
mreiferson
force-pushed
the
http_logs_610
branch
from
8a9f047 to
0381117
Compare
Merged
|
LGTM; there are probably a dozen ways to approach this, but this one feels fine. |
| router.Handle("GET", "/node/:node", http_api.Decorate(s.nodeHandler, log)) | ||
| router.Handle("GET", "/topic/:topic", http_api.Decorate(s.topicHandler, log)) | ||
| router.Handle("GET", "/topic/:topic/:channel", http_api.Decorate(s.channelHandler, log)) | ||
| router.Handle("GET", "/static/:asset", http_api.Decorate(s.embeddedAssetHandler, log)) |
There was a problem hiding this comment.
@mreiferson turns out this doesn't work because log doesn't handle the response leaving nothing to render the response from the handler (ie: s.embededAssetHandler) into the response.
The effect is that requests for static assets return a 0 length content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a log decorator as middleware for the HTTP handlers.
Notably, this does not log /pub /mpub (should it?).
This also adds 404, 405, and "panic" handlers so that those responses
are consistently formatted.
RFR @jehiah