nsqd: optimize GetTopic / fix data race #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch on the race in Can you add a bench test and share before/after metrics for performance change from the |
|
OK, I will add some benchmark test later. |
|
also LGTM, I am interested in benchmarks but can you also squash down into two separate commits |
|
thanks for all these fixes @absolute8511 |
mreiferson
changed the title
2.try rlock first to reduce write lock
absolute8511
force-pushed
the
optimize-lock
branch
from
3d9a6fa to
03650ee
Compare
|
👍 |
mreiferson
added a commit
that referenced
this pull request
Jan 16, 2016
nsqd: optimize GetTopic / fix data race
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AggregateChannelE2eProcessingLatencythe channels should be copied out with lock and this lock should be outside the stream merge. Also the GetTopic is hot while pub message, so we should avoid write lock as more as possible.