Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: install windows binaries with .exe extension #726

Merged
merged 3 commits into from
Mar 10, 2016

Conversation

ploxiln
Copy link
Member

@ploxiln ploxiln commented Mar 10, 2016

also threw in some other subjective Makefile refactoring, but would be fine with undoing it

new dist.sh output:

... building v0.3.7 for freebsd/amd64
go build  -o build/nsqd ./apps/nsqd
go build  -o build/nsqlookupd ./apps/nsqlookupd
go build  -o build/nsqadmin ./apps/nsqadmin
go build  -o build/nsq_pubsub ./apps/nsq_pubsub
go build  -o build/nsq_to_nsq ./apps/nsq_to_nsq
go build  -o build/nsq_to_file ./apps/nsq_to_file
go build  -o build/nsq_to_http ./apps/nsq_to_http
go build  -o build/nsq_tail ./apps/nsq_tail
go build  -o build/nsq_stat ./apps/nsq_stat
go build  -o build/to_nsq ./apps/to_nsq
install -m 755 -d /var/folders/ny/tsl8z9qx453630cxnzw0_dj80000gn/T/nsq.l5IgN3bd/nsq-0.3.7.freebsd-amd64.go1.5.3/bin
for APP in nsqd nsqlookupd nsqadmin nsq_pubsub nsq_to_nsq nsq_to_file nsq_to_http nsq_tail nsq_stat to_nsq ; do install -m 755 build/$APP /var/folders/ny/tsl8z9qx453630cxnzw0_dj80000gn/T/nsq.l5IgN3bd/nsq-0.3.7.freebsd-amd64.go1.5.3/bin/$APP ; done
/var/folders/ny/tsl8z9qx453630cxnzw0_dj80000gn/T/nsq.l5IgN3bd ~/scratch/nsq
a nsq-0.3.7.freebsd-amd64.go1.5.3
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsq_pubsub
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsq_stat
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsq_tail
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsq_to_file
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsq_to_http
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsq_to_nsq
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsqadmin
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsqd
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/nsqlookupd
a nsq-0.3.7.freebsd-amd64.go1.5.3/bin/to_nsq
~/scratch/nsq
rm -fr build
... building v0.3.7 for windows/amd64
go build  -o build/nsqd ./apps/nsqd
go build  -o build/nsqlookupd ./apps/nsqlookupd
go build  -o build/nsqadmin ./apps/nsqadmin
go build  -o build/nsq_pubsub ./apps/nsq_pubsub
go build  -o build/nsq_to_nsq ./apps/nsq_to_nsq
go build  -o build/nsq_to_file ./apps/nsq_to_file
go build  -o build/nsq_to_http ./apps/nsq_to_http
go build  -o build/nsq_tail ./apps/nsq_tail
go build  -o build/nsq_stat ./apps/nsq_stat
go build  -o build/to_nsq ./apps/to_nsq
install -m 755 -d /var/folders/ny/tsl8z9qx453630cxnzw0_dj80000gn/T/nsq.o3E3opyF/nsq-0.3.7.windows-amd64.go1.5.3/bin
for APP in nsqd nsqlookupd nsqadmin nsq_pubsub nsq_to_nsq nsq_to_file nsq_to_http nsq_tail nsq_stat to_nsq ; do install -m 755 build/$APP /var/folders/ny/tsl8z9qx453630cxnzw0_dj80000gn/T/nsq.o3E3opyF/nsq-0.3.7.windows-amd64.go1.5.3/bin/$APP.exe ; done
/var/folders/ny/tsl8z9qx453630cxnzw0_dj80000gn/T/nsq.o3E3opyF ~/scratch/nsq
a nsq-0.3.7.windows-amd64.go1.5.3
a nsq-0.3.7.windows-amd64.go1.5.3/bin
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsq_pubsub.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsq_stat.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsq_tail.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsq_to_file.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsq_to_http.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsq_to_nsq.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsqadmin.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsqd.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/nsqlookupd.exe
a nsq-0.3.7.windows-amd64.go1.5.3/bin/to_nsq.exe
~/scratch/nsq
rm -fr build

@mreiferson
Copy link
Member

I like it, thanks @ploxiln

mreiferson added a commit that referenced this pull request Mar 10, 2016
make: install windows binaries with .exe extension
@mreiferson mreiferson merged commit 73cb438 into nsqio:master Mar 10, 2016
@ploxiln ploxiln deleted the make_win_ext branch April 22, 2016 22:33
@mreiferson mreiferson added the bug label Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants