nsqd: update and fix for latest go-options #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually cleans this up a bunch, RFR @jehiah |
| ClientTimeout: 60 * time.Second, | ||
|
|
||
| MaxHeartbeatInterval: 60 * time.Second, |
There was a problem hiding this comment.
removing these presents a challenge for those importing nsqd directly though right?
There was a problem hiding this comment.
Thinking on this a little more I think it'd be better to preserve the defaults here in NewOptions() and just change the order in main() to get NewOptions() first and pass that in to nsqFlagset(), so that the defaults come from the nsqd package, not apps/nsqd
There was a problem hiding this comment.
Good points, agreed, will update.
mreiferson
force-pushed
the
go-options-update
branch
from
5e9f536 to
5c6990a
Compare
|
updated |
|
@mreiferson can you look into why CI isn't happy yet? (LGTM otherwise) |
|
let's see how this run does |
|
👍 LGTM. squash? |
mreiferson
force-pushed
the
go-options-update
branch
from
5df8ec8 to
b4ae7dc
Compare
|
🔨d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a replacement for #736, thanks @FlamingTree!