Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: DecodeMessage skip bytes Buffer, reducing alloc overhead #740

Merged
merged 1 commit into from
Apr 15, 2016
Merged

nsqd: DecodeMessage skip bytes Buffer, reducing alloc overhead #740

merged 1 commit into from
Apr 15, 2016

Conversation

Dieterbe
Copy link
Contributor

this is the nsqd equivalent of a very similar change in go-nsq:
nsqio/go-nsq#175

@Dieterbe
DecodeMessage: skip bytes Buffer, reducing alloc overhead
0c28816 
this is the nsqd equivalent of a very similar change in go-nsq:
nsqio/go-nsq#175
@mreiferson
Copy link
Member

LGTM

@mreiferson mreiferson merged commit 6f99c0b into nsqio:master Apr 15, 2016
@mreiferson mreiferson changed the title DecodeMessage: skip bytes Buffer, reducing alloc overhead nsqd: DecodeMessage skip bytes Buffer, reducing alloc overhead Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dieterbe @mreiferson