nsqadmin: add /config API #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides the ability to modify the configuration nsqadmin for setting `nsqlookupd_http_addresses` to support dynamic configuration. Closes nsqio#769
|
Perfect, thanks @kenjones-cisco. Note: in the future feel free to push new commits (or rewrite history) in the same branch on a single PR, no need to close and open a new one as we review. It has it's tradeoffs, but we like to have all the context in one place! |
|
I'll take the git push --force in the future. Bad habit due to work of never using --force. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the ability to modify the configuration nsqadmin for setting
nsqlookupd_http_addressesto support dynamic configuration.Closes #769