apps/to_nsq: add --rate to throttle message creation #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var throttleEnabled bool | ||
| if *rate >= 1 { | ||
| throttleEnabled = true | ||
| } |
There was a problem hiding this comment.
throttleEnabled := *rate >= 1
|
I feel like there are some not-so-important race conditions, so otherwise LGTM |
jehiah
force-pushed
the
to_nsq_rate_788
branch
from
52d352b to
12fa5d2
Compare
|
comments addressed. 🔨 'd and RFM |
|
❤️ |
|
Have you looked at |
|
@judwhite interesting. Nope never seen/noticed that package before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--rate=intoption toto_nsqwhich will throttle the message creation to that rate per second:This is helpful when you want to load a large dataset into a message driven pipeline w/o causing a backlog of messages to process on the NSQ side.