nsqd: bump go-options / log when we can't get channels for pre-creation #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
force-pushed
the
get-channel-error
branch
from
3567a97 to
473cd44
Compare
mreiferson
changed the title
mreiferson
force-pushed
the
get-channel-error
branch
from
73ae1a0 to
d347459
Compare
|
RFR @jehiah |
jehiah
requested changes
Dec 28, 2016
| channelNames, _ := n.ci.GetLookupdTopicChannels(t.name, lookupdHTTPAddrs) | ||
| channelNames, err := n.ci.GetLookupdTopicChannels(t.name, lookupdHTTPAddrs) | ||
| if err != nil { | ||
| n.logf("ERROR: failed to get channels for pre-creation for topic %s - %s", t.name, err) |
There was a problem hiding this comment.
Technically we failed to query all lookupd's so we don't know if the result is deficient in any way. We may have still gotten channels for pre-creation from available lookupd's. Rephrase this and/or make different error messages based on channelNames?
There was a problem hiding this comment.
Fair point, will update 👍
mreiferson
force-pushed
the
get-channel-error
branch
from
d347459 to
da67962
Compare
mreiferson
force-pushed
the
get-channel-error
branch
from
da67962 to
7a485a5
Compare
jehiah
approved these changes
Dec 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses proposal (1) and (2) of #826