dep; update travis, dist, test, coverage #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
reviewed
Oct 29, 2017
| rm -rf $DIR/.godeps | ||
| mkdir -p $DIR/.godeps | ||
| export GOPATH=$DIR/.godeps:$GOPATH | ||
| GOPATH=$DIR/.godeps gpm install |
There was a problem hiding this comment.
I've always liked that dist.sh preserves the state of my GOPATH, should we maintain that property?
There was a problem hiding this comment.
@mreiferson With dep you don't have to change GOPATH, it uses ./vendor. Maybe I misunderstood you?
|
@mreiferson Squashed. Tests also take a bit to execute, let me know if you want to drop |
judwhite
changed the title
|
I re-started that one sub-test and it passed. (I intended to copy the failure details and make an issue for the flaky test, but wasn't being careful and lost the copy.) |
|
this is cool, thanks. @judwhite last request, update the docs on http://nsq.io/deployment/installing.html#building-from-source? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to nsqio/go-nsq#218
Ready for review. @mreiferson @jehiah @ploxiln