Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsq_tail: mv stdout logging to stderr #991

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented Jan 29, 2018

This fixes a regression from #957 which added a fmt.Printf line which outputs to stdout. stdout is used exclusively by nsq_tail to output data, and logging should be on stderr via the log package.

$ nsq_tail --topic=internal_request_metrics --channel=blah#ephemeral --nsqd-tcp-address=127.0.0.1:4150 2>/dev/null
Adding consumer for topic: internal_request_metrics

@jehiah jehiah self-assigned this Jan 29, 2018
@jehiah jehiah added the bug label Jan 29, 2018
@jehiah jehiah requested review from mreiferson and ploxiln January 29, 2018 21:53
Copy link

@kpurdon kpurdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mreiferson
Copy link
Member

whooops

@mreiferson mreiferson merged commit 2305c6f into nsqio:master Jan 29, 2018
@mreiferson mreiferson deleted the nsq_tail_stdout_991 branch January 29, 2018 21:59
@ploxiln
Copy link
Member

ploxiln commented Jan 29, 2018

thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants