Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NS1004 false positive when using argument matcher in a separate method #213

Closed
Tum4ik opened this issue Sep 17, 2023 · 0 comments · Fixed by #214
Closed

NS1004 false positive when using argument matcher in a separate method #213

Tum4ik opened this issue Sep 17, 2023 · 0 comments · Fixed by #214
Labels
bug Something isn't working
Milestone
1.0.17

Comments

@Tum4ik
Copy link

Tum4ik commented Sep 17, 2023 •
edited
Loading

When the argument matcher is quite complex, there is a natural wish to extract the matcher to a separate method.
But in that case the analyzer produces a warning.

image

You can check the example in my repo: https://github.com/Tum4ik/just-clipboard-manager/blob/main/Tests/Tum4ik.JustClipboardManager.UnitTests/Services/PasteServiceTests.cs
@tpodolak tpodolak added the bug Something isn't working label Sep 22, 2023
tpodolak added a commit that referenced this issue Sep 23, 2023
@tpodolak
GH-213 - do not report NS1004 when arg matcher is used directly in re…
bd02212 
…turn statement
tpodolak added a commit that referenced this issue Sep 23, 2023
@tpodolak
GH-213 - do not report NS1004 when arg matcher is used directly in re…
b0fe314 
…turn statement
tpodolak added a commit that referenced this issue Sep 23, 2023
@tpodolak
GH-213 - do not report NS1004 when arg matcher is used directly in re…
9dbe8e9 
…turn statement
tpodolak added a commit that referenced this issue Sep 23, 2023
@tpodolak
GH-213 - do not report NS1004 when arg matcher is used directly in re…
e996107 
…turn statement
@tpodolak tpodolak mentioned this issue Sep 23, 2023
Merged
tpodolak added a commit that referenced this issue Dec 9, 2023
@tpodolak
Merge pull request #214 from nsubstitute/GH-213-arg-matcher-false-pos…
417e4e7 
…itives

GH-213 - do not report NS1004 when arg matcher is used directly in return statement
@tpodolak tpodolak modified the milestones: 1.0.16, 1.0.17 Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.17
2 participants
@tpodolak @Tum4ik