Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from AppVeyor to GitHub Actions #754

Merged
merged 7 commits into from
Nov 19, 2023

Conversation

alexandrnikitin
Copy link
Member

@alexandrnikitin alexandrnikitin commented Nov 15, 2023

The motivation is that GitHub Actions is easier to use and offers way more options to work with CI.

- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.5'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtchepak do we want to update it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i'm locally on 2.6.5 at the moment. 😅 Happy to update to the latest version that doesn't break anything 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to update it but it looks like we need to update bundler and packages locally first.
I'm merging as is. Let's do it in a separate PR.

Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @alexandrnikitin ! Thanks for doing this.

I noticed GitHubActions is exposing ClrJobAttribute obsoletion warnings. Would be great to address this in another commit if it's a simple fix.

- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i'm locally on 2.6.5 at the moment. 😅 Happy to update to the latest version that doesn't break anything 😊

@alexandrnikitin alexandrnikitin merged commit a32dc4e into nsubstitute:main Nov 19, 2023
18 checks passed
@alexandrnikitin alexandrnikitin deleted the appveyor-to-github branch November 19, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants