-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from AppVeyor to GitHub Actions #754
Move from AppVeyor to GitHub Actions #754
Conversation
- name: Setup Ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: '2.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtchepak do we want to update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i'm locally on 2.6.5 at the moment. 😅 Happy to update to the latest version that doesn't break anything 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to update it but it looks like we need to update bundler and packages locally first.
I'm merging as is. Let's do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @alexandrnikitin ! Thanks for doing this.
I noticed GitHubActions is exposing ClrJobAttribute
obsoletion warnings. Would be great to address this in another commit if it's a simple fix.
- name: Setup Ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: '2.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i'm locally on 2.6.5 at the moment. 😅 Happy to update to the latest version that doesn't break anything 😊
The motivation is that GitHub Actions is easier to use and offers way more options to work with CI.