Format NSubstitute.csproj layout + remove unusable code for net4.5 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romfos
changed the title
alexandrnikitin
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Nice! Thank you!
Remove Microsoft.SourceLink.GitHub (starting from .net 8 included in sdk)
One caveat is we need to use .NET 8 SDK for release builds. cc @dtchepak
| @@ -247,21 +247,12 @@ private static object FromException(object value, Exception exception) | |||
|
|
|||
| private static Task TaskFromException(Exception ex) | |||
| { | |||
| #if NET45 | |||
| return new Task(() => throw ex); | |||
| #else | |||
| return Task.FromException(ex); | |||
There was a problem hiding this comment.
nit: we don't need a wrapper method after the change and this can be inlined
There was a problem hiding this comment.
you are totally right, done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
NSubstitute.csproj layout was updated to more classical:
note: no product changes, no need to release new nuget package