-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Throws for exceptions to the docs #795
Conversation
I dont know how to fix the compilation (because of the needed using) |
I think I fixed it. But not sure if it's the best way. |
I'm now confused, we have Throw and Throws, and both have the comments:
and
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the doc updates! 🙇
Left some minor comments before we merge.
``` | ||
|
||
### Returns | ||
Another way is to use the underlying method, `.Returns`. See also [Callbacks](/help/callbacks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: missing trailing full stop.
See also [Callbacks](/help/callbacks).
It's confusing that the docs talk about using .Returns, while we have .Throws (not sure from which version)
Not sure what I should do with the date in de post name. Should I update it?
(Please squash on merge PR)
Fixes #750