Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libc dependency #336

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Remove libc dependency #336

merged 2 commits into from
Feb 14, 2025

Conversation

ntBre
Copy link
Owner

@ntBre ntBre commented Feb 14, 2025

This will require adding > pbqff.out 2> pbqff.log to the script calling pbqff, and it also makes the pbqff.out check for the --overwrite flag slightly dubious, but it's nice to drop the unsafe code and also the libc dependency.

@ntBre ntBre merged commit d651277 into master Feb 14, 2025
7 checks passed
@ntBre ntBre deleted the brent/remove-libc branch February 14, 2025 02:27
ntBre added a commit that referenced this pull request Feb 15, 2025
This reverts commit d651277.

in the monorepo, libc gets pulled in by psqs anyway, so it really doesn't matter
and it *is* convenient to do the redirection internally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant