calibrationd: start faster by not waiting for carParams (commaai#24976)

* calibrationd: start faster by not waiting for carParams * fix process replay * update ref
ntegan1 · Jul 12, 2022 · 7144c0b · 7144c0b
1 parent 65f2b1e
commit 7144c0b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/selfdrive/locationd/calibrationd.py b/selfdrive/locationd/calibrationd.py
@@ -12,7 +12,7 @@
 import numpy as np
 from typing import List, NoReturn, Optional
 
-from cereal import car, log
+from cereal import log
 import cereal.messaging as messaging
 from common.conversions import Conversions as CV
 from common.params import Params, put_nonblocking
@@ -63,7 +63,7 @@ class Calibrator:
   def __init__(self, param_put: bool = False):
     self.param_put = param_put
 
-    self.CP = car.CarParams.from_bytes(Params().get("CarParams", block=True))
+    self.not_car = False
 
     # Read saved calibration
     params = Params()
@@ -193,7 +193,7 @@ def get_msg(self) -> capnp.lib.capnp._DynamicStructBuilder:
     liveCalibration.rpyCalib = smooth_rpy.tolist()
     liveCalibration.rpyCalibSpread = self.calib_spread.tolist()
 
-    if self.CP.notCar:
+    if self.not_car:
       extrinsic_matrix = get_view_frame_from_road_frame(0, 0, 0, model_height)
       liveCalibration.validBlocks = INPUTS_NEEDED
       liveCalibration.calStatus = Calibration.CALIBRATED
@@ -213,7 +213,7 @@ def calibrationd_thread(sm: Optional[messaging.SubMaster] = None, pm: Optional[m
   set_realtime_priority(1)
 
   if sm is None:
-    sm = messaging.SubMaster(['cameraOdometry', 'carState'], poll=['cameraOdometry'])
+    sm = messaging.SubMaster(['cameraOdometry', 'carState', 'carParams'], poll=['cameraOdometry'])
 
   if pm is None:
     pm = messaging.PubMaster(['liveCalibration'])
@@ -224,6 +224,8 @@ def calibrationd_thread(sm: Optional[messaging.SubMaster] = None, pm: Optional[m
     timeout = 0 if sm.frame == -1 else 100
     sm.update(timeout)
 
+    calibrator.not_car = sm['carParams'].notCar
+
     if sm.updated['cameraOdometry']:
       calibrator.handle_v_ego(sm['carState'].vEgo)
       new_rpy = calibrator.handle_cam_odom(sm['cameraOdometry'].trans,

diff --git a/selfdrive/test/process_replay/process_replay.py b/selfdrive/test/process_replay/process_replay.py
@@ -277,7 +277,8 @@ def ublox_rcv_callback(msg):
     proc_name="calibrationd",
     pub_sub={
       "carState": ["liveCalibration"],
-      "cameraOdometry": []
+      "cameraOdometry": [],
+      "carParams": [],
     },
     ignore=["logMonoTime", "valid"],
     init_callback=get_car_params,