Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support existing running sc #24

Merged
merged 3 commits into from
Jan 17, 2018

Conversation

holdenk
Copy link
Collaborator

@holdenk holdenk commented Jan 17, 2018

Support launching a coffee boat on an already running Spark context.

…tes of Spark (not running at all, running, context shut down gateway running) and we handle all of them (mini-yay). Still need to handle running better (e.g. no ship re-launch to add a single package).
# Handle active/already running contexts.
sc = pyspark.context.SparkContext._active_spark_context
if sc is not None:
print("Adding {0} & {1} to existing sc".format(zip_target, runner_script_path))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question for @holdenk @rgbkrk: which versions of Python will coffee_boat run? If Python 3.6 or higher, we can go with the far simpler f-strings. If this needs to run on 3.4 or 2.7, whelp, we are stuck with `format(blah, blah, blah)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably for the best adoption, I'd opt for 2.7+ and 3.4+.

Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @holdenk.

@willingc willingc merged commit e259feb into nteract:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants