-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create epic for launching a jupyter ws kernel #2391
Conversation
21f76c7
to
7347a82
Compare
One thing that
Thoughts @theengineear? We mostly just need consistency among these while being able to straddle localhost (HTTP) and remote authenticated servers on HTTPS. |
Notes from the jupyter notebook server as to why the jupyter extension used |
Is there any reason for us not to required that users of the lib just pass in the full URL, else we just bail in rx-jupyter? |
I think that's a good standard. |
06afff4
to
130948d
Compare
Rebased this one to stay up to date, going to town on finishing it off now. |
93ccb96
to
dedae0f
Compare
The way I'm running this right now (since we don't have the contents API and {
type: 'LAUNCH_KERNEL_BY_NAME',
kernelSpecName: 'python3',
cwd: '/'
} |
ec85256
to
417fdf5
Compare
💥 |
417fdf5
to
26d67e5
Compare
26d67e5
to
b3b84e1
Compare
This now also sets the kernel into the app record. Execution works as does autocomplete. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Howdy! I'm 🔓🤖! In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days. Feel free to open a new issue for related bugs and link to relevant comments from this thread. |
This sets up a kernel launching epic that launches kernels on jupyter hosts.
🎉 Connections to remote kernels, ready for desktop, play, and the nteract web app. Connecting this up to Desktop is not a focus for this PR, nor is the UI/config for doing so. The first target is the jupyter extension.
TODO:
rx-jupyter
to adapt the URL based onlocation.origin
as necessary