Add menu to nteract-on-jupyter #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds a dependency to rc-menu* - hooks up some cell-level actions - tests that user clicks trigger expected actions - adds snapshots to lock down structure/style *note that we lock this dependency down because we copy/alter css
|
|
rgbkrk
reviewed
Jan 25, 2018
| // We export this for testing purposes. | ||
| export { PureNotebookMenu }; | ||
|
|
||
| export default NotebookMenu; |
rgbkrk
reviewed
Jan 25, 2018
| // to alter how the actions work to just target the currently focused cell. | ||
| // That said, we *may* not have a great way of getting around this as we'll need | ||
| // information about the current document to decide which menu items are | ||
| // available... |
There was a problem hiding this comment.
Yeah that's a tricky one. We probably need to work with the focused cell and if we need to create more actions (like the "run all").
rgbkrk
approved these changes
Jan 25, 2018
|
I'm confused as to why that's failing on Appveyor, I'm going to go ahead and merge it, clear the cache on appveyor and figure out the build setup. |
|
Howdy! I'm 🔓🤖! In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days. Feel free to open a new issue for related bugs and link to relevant comments from this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 first pass at some minimal menu functionality
I went with code-completeness > feature completeness. I.e., there's much more to flesh out here, but I tried my best to get this code right on the first pass so that we can easily extend.
TODO:
notebook-menupresentation component (i made it a dir withindex.jsso it matches other components there)