Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Naver protocol support #2610

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Add Naver protocol support #2610

merged 1 commit into from
Nov 1, 2024

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Naver is kind of a South Korean Google.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@IvanNardi
Copy link
Collaborator

Rebased...

Copy link

sonarcloud bot commented Nov 1, 2024

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. You did the right thing with the pcap in the first version, and the workaround for the big-endian issue is perfect. Thank you

@IvanNardi IvanNardi merged commit 137d87f into ntop:dev Nov 1, 2024
35 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-proto/naver branch November 1, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants