Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple resources in config.yaml, each with different expected_metrics #34

Merged

Conversation

SafariMonkey
Copy link
Contributor

This pull request allows test writers to specify multiple resources like so:

resources:
  -
    resource:
      account_id: "5be71766-6c4c-47b8-869a-9dd1e5db3451"
      id: "b2989523-3bac-4f14-ba43-7ad7453eff0e"
    expected_metrics:
      - cpu-usage
      - memory-usage
  -
    resource:
      account_id: "5be71766-6c4c-47b8-869a-9dd1e5db3451"
      id: "14f06ece-9da7-468e-a7ca-e9554fdbda10"
    expected_metrics:
      - disk-usage

This is very useful in situations where there are multiple types of resource which might take different code paths or have separate mappings.

This still supports the old method of specifying resources and expected metrics:

resource:
  account_id: "5be71766-6c4c-47b8-869a-9dd1e5db3451"
  id: "b2989523-3bac-4f14-ba43-7ad7453eff0e"
expected_metrics:
  - cpu-usage
  - memory-usage

@benpaxton-hf benpaxton-hf requested a review from geodimm August 25, 2017 14:03
@geodimm geodimm merged commit 1ab1e6b into ntt-nflex:master Aug 25, 2017
@SafariMonkey SafariMonkey deleted the allow-multiple-test-resources branch August 25, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants