[WIP] "flexer new" command to create working examples of modules

[tintoy]

Note: This idea is a work-in-progress; I'm seeking feedback :)

Example usage:

$ flexer new -t resource_connector -n my_resource_connector

This creates a new resource connector:

$ ls ./my_resource_connector
main.py
test-data.json
run.sh

test-data.json is populated using information discovered via the CMP API (e.g. valid account and provider Ids).

You can then run ./run.sh to invoke module. run.sh simply invokes flexer run get_resources --event="$(cat ./test-data.json)".

Would love some feedback, if you have any.

[geodimm]

Looks great, thanks a lot for the effort! When you feel like the feature is complete, please let us know so we can merge it :)
One small comment is may be to use click.echo instead of the print statement as it takes care of encoding and flushes to the appropriate file descriptors.

[tintoy]

Thanks - will do :)

[geodimm]

Hi @tintoy ,

I was wondering if you're happy with what you have so far :) If you are, we can merge this and add further enhancements in the future if necessary.

[tintoy]

Sorry! Been flat out but I'll review it first thing this morning and get back to you ASAP :)

[tintoy]

If you're happy with where I've put things (layout-wise), then it should be ok to merge. I'd like to write some proper tests as the next PR though :)

[geodimm]

Hi there,

Sorry for the late response. Lots of stuff to do around here... I've just tried it on my laptop and found a few small issues. Hope you can address them when you have time :) Also, I know it's nitpicking, but could you lint the code so we don't get lines longer than 80 chars, etc.

[geodimm]

There's a missing .json() call on the response object here.

[tintoy]

Oops! Sorry, I should have tested that. I'll fix it right up.

[geodimm]

if the templates_dir does not exist, the script fails with OSError: [Errno 2] No such file or directory. We should check if it exists before trying to render templates.

[tintoy]

BTW, I use PyCharm - it's always linting (PEP8), but I don't normally follow the maximum 80 chars limit. But I'm happy to do so here and will sort that out now.

[tintoy]

I thought the idea with Python was to ask for forgiveness rather than permission (i.e. catch the error if it comes up, rather than check if it exists beforehand). I don't mind checking first though, it's what I'm used to :)

[geodimm]

Yeah, that's a good point. In that case the friendlier message will hint the user the program hasn't just crashed unexpectedly :) Thanks for the styling fixes too. We have no strong feelings so don't feel obliged to do it :)

[tintoy]

Yay!