fix #150

ntzm · Jan 14, 2020 · 0a52016 · 0a52016
1 parent b2f127d
commit 0a52016
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/UriString.php b/src/UriString.php
@@ -452,6 +452,11 @@ private static function filterRegisteredName(string $host): string
         // @codeCoverageIgnoreEnd
 
         $retval = idn_to_ascii($formatted_host, 0, INTL_IDNA_VARIANT_UTS46, $arr);
+
+        if ($arr === []) {
+            throw new SyntaxError(sprintf('Host `%s` is not a valid IDN host', $host));
+        }
+
         if (0 !== $arr['errors']) {
             throw new SyntaxError(sprintf('Host `%s` is not a valid IDN host : %s', $host, self::getIDNAErrors($arr['errors'])));
         }

diff --git a/tests/UriStringTest.php b/tests/UriStringTest.php
@@ -781,6 +781,7 @@ public function invalidUriProvider(): array
             'invalid Host with fullwith (1)' =>  ['http://％００.com'],
             'invalid host with fullwidth escaped' =>  ['http://%ef%bc%85%ef%bc%94%ef%bc%91.com],'],
             'invalid pseudo IDN to ASCII string' => ['http://xn--3/foo.'],
+            'invalid IDN' => ['//:�@�����������������������������������������������������������������������������������������/'],
         ];
     }