Fix decoding bug, improve docs, update deps #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade nubank/clj-github-app from 0.2.1 to 0.3.0 - Mark optional dependencies with scope provided - clj-commons/clj-yaml - http-kit.fake - dev.nubank/clj-github-mock
Also, improve documentation about credentials.
base64 decoding each line and then joining decoded lines is wrong, because the encoded base64 string may have a line break in the middle of a multibyte codepoint. The correct behavior is to strip all line breaks first, and only them decode the entire string.
marcobiscaro2112
changed the title
scottbale
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review per commit is recommended.
get-content!get-content-rawfunction that decodes file's content to a byte arraygh auth token