[Centennial] #275
Merged
[Centennial] #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gozer
commented
Nov 27, 2017
•
gozer
commented
- Upgrade to Xenial
- Upgrade to Prometheus 2.0
- Get rid of EFS
- Use new 2.0 snapshot API for hourly backups
gozer
force-pushed
the
feature/centennial
branch
from
11e1af9 to
7e33219
Compare
tinnightcap
reviewed
Nov 28, 2017
| @@ -138,6 +138,7 @@ metrics: | |||
| aws_dimension_select_regex: | |||
| FunctionName: [ "(.*)-{{ getv "/config/Arena" }}(.*)" ] | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Is this intentional? It looks odd to me.
nubis/files/rules/nubis.yml
Outdated
| severity: critical | ||
| annotations: | ||
| description: Healthy prometheus servers count isn't 1 | ||
| summary: Unexpected number of healthy Fluentd nodes |
There was a problem hiding this comment.
Should be "Unexpected number of healthy Prometheus nodes"
nubis/files/rules/nubis.yml
Outdated
| severity: critical | ||
| annotations: | ||
| description: Healthy alertmanager servers count isn't 1 | ||
| summary: Unexpected number of healthy Fluentd nodes |
There was a problem hiding this comment.
Should read "Unexpected number of healthy AlertManager nodes"
tinnightcap
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.