Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gesture-handler-2.0 #166

Closed

Conversation

LunatiqueCoder
Copy link

@LunatiqueCoder LunatiqueCoder commented Nov 12, 2023

Solves #140

While it works very well with LunatiqueCoder/expo-drax-example (which is forked from: nuclearpasta/react-native-drax-example) , we managed to reproduce in production this particular issue: software-mansion/react-native-gesture-handler#2674.

As described in the above link and also in #165, this happens when there are a lot of GestureDetectors from the new gesture-handler API. Reducing the number of GestureDetectors (or DraxViews in our case) will make the issue less annoying or even very hard to reproduce.

I believe this should stay as a draft until we manage to fix it OR we can try to have a useLegacyGestureHandler prop.

While I also had to add some type guards, here are the actual changes:

@LunatiqueCoder
Copy link
Author

We firstly implemented react-native-reanimated with the goal of changing as little source code as possible. You can see a video here: https://x.com/LunatiqueCoder/status/1721982083902394694?s=20

Then when we also upgraded gesture-handler we ran into this issue: software-mansion/react-native-gesture-handler#2674 so we decided to isolate the changes related to gesture-handler in order to create a reproduction repository. However, upon further investigation, we realised there's a possibility of fixing this issue on our end as gesture-handler is designed to function more seamlessly with reanimated than standalone. Ugh, this is going to be fun. Closing this in favour of another upcoming reanimated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant