Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bib2df parsing issues #49

Open
mattwarkentin opened this issue Jun 9, 2022 · 3 comments
Open

bib2df parsing issues #49

mattwarkentin opened this issue Jun 9, 2022 · 3 comments

Comments

@mattwarkentin
Copy link
Contributor

mattwarkentin commented Jun 9, 2022 •
edited
Loading

Hi @nucleic-acid,

Cool package!

I was running into a frustrating issue when I tried to play around with it, but it turns out it is caused by bib2df. A related issue is found here: ropensci/bib2df#53

Unfortunately, Google Scholar provides BibTeX citations without whitespace around the equals sign, by default. So any citation grabbed from Google Scholar fails when parsed by bib2df and thus creates incomplete visual citations via drop_name().

Just something you might want to know/guard against in this package until it is resolved in that package.
@nucleic-acid
Copy link
Owner

Thanks @mattwarkentin for the feedback!
Since I never pulled references from Google Scholar, I wasn't aware of this issue. Thanks for pointing it out.

I used bib2df, as bibtex was orphaned on CRAN and back then it was not clear whether it would ever return. I'll have to think on how to catch this problem. If you have suggestions, please do share them!

@nucleic-acid
Copy link
Owner

Seeing the active development on the bibtex package (ropensci/bibtex#45), i might switch back to that on the long run.

@mattwarkentin
Copy link
Contributor Author

Thanks for the quick reply.

Yes, perhaps bibtex would be a good long-term solution if it is actively being maintained now. So long as it meets the same needs as bib2df.

LukasWallrich added a commit to LukasWallrich/namedropR that referenced this issue Dec 11, 2022
@LukasWallrich
Allow to pass BibTex as character to drop_name()
2783015 
This allows users to copy-paste BibTex from (e.g.) Google Scholar 

```r
drop_name("@Article{rungta2022geographic,
  title={Geographic Citation Gaps in NLP Research},
  author={Rungta, Mukund and Singh, Janvijay and Mohammad, Saif M and Yang, Diyi},
  journal={arXiv preprint arXiv:2210.14424},
  year={2022}
}")
```

In that context, it also deals with nucleic-acid#49 - while we should prob not edit bib-files here, it seems fair to add a workaround for this interactive use until bib2df addresses the issue?
@LukasWallrich LukasWallrich mentioned this issue Dec 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattwarkentin @nucleic-acid