Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should nuclio-sdk-dotnetcore Context class support the same fields as the Context in Go? #10

Open
ballcoach12 opened this issue Aug 15, 2022 · 0 comments
Open

Should nuclio-sdk-dotnetcore Context class support the same fields as the Context in Go? #10

ballcoach12 opened this issue Aug 15, 2022 · 0 comments

Comments

@ballcoach12
Copy link
Contributor

I notice that the .NET Context class only supports one property, "Logger", while the Go SDK Context class supports DataBinding, Platform, WorkerID, UserData, FunctionName, FunctionVersion, TriggerKind, TriggerName, and WorkerAllocationName.

Should the .NET Context (and other classes) be updated in order to support these fields as well?
ballcoach12 added a commit to ballcoach12/nuclio-sdk-dotnetcore that referenced this issue Oct 14, 2022
@ballcoach12
Modified the Context.cs file to partially address nuclio#10. Added "N…
5d3cb3f 
…ame" and "UserData" fields.

Modified tests.csproj to update the .NET Framework version to .NET Core 3.1 from 2.0.
Updated JsonTests.cs to test for string values in Event (tests were failing because of invalid types)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ballcoach12