Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refund calculation bug in BetaProgramInitiator (part 2) #230

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

cygnusv
Copy link
Member

@cygnusv cygnusv commented Jan 24, 2024

(Continuation of #228)

As part of a longer-term solution that doesn't involve the Threshold Council and/or Treasury Guild managing refunds manually, this PR sets the refunds to be 100% so that the complete fee goes back to the BetaProgramInitiator, and then to the original adopter.

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@cygnusv cygnusv marked this pull request as ready for review January 26, 2024 06:45
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

(Already deployed and used on mainnet)

@KPrasch KPrasch merged commit ebee5d2 into nucypher:main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants