Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI ordering for lynx registry file - was incorrect due to my faulty merging after deployment. #236

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

derekpierre
Copy link
Member

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
Fixes lynx registry after latest deployment - #234 . The ordering was incorrect after #235 .

Properly merge the deployment registry and latest lynx into a separate temporary file first then replaced lynx.json.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@derekpierre
Copy link
Member Author

Once merged, we'd need to copy over the updated file to nucypher - either as part of nucypher/nucypher#3419 or as a follow-up PR.

@derekpierre
Copy link
Member Author

Bump on this - once merged the updated file should be added in 3419.

@KPrasch KPrasch merged commit fe27aae into nucypher:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants