Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated TACoApplication deployment #296

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Updated TACoApplication deployment #296

merged 4 commits into from
Aug 15, 2024

Conversation

cygnusv
Copy link
Member

@cygnusv cygnusv commented Jul 29, 2024 •
edited by derekpierre
Loading

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@KPrasch
Copy link
Member

KPrasch commented Aug 7, 2024

Rebased over 686ae10

@derekpierre derekpierre mentioned this pull request Aug 12, 2024
Merged
23 tasks
@KPrasch KPrasch changed the base branch from epic-subscription to main August 14, 2024 08:13
@cygnusv cygnusv marked this pull request as ready for review August 14, 2024 08:46
@cygnusv @derekpierre
Don't change TACoApp address in registry, since it's proxied
c763df9 
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
derekpierre
derekpierre previously requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting this marker for now until we take a deeper look at the deployment script.

derekpierre
derekpierre approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@derekpierre
Copy link
Member

Council already upgraded the proxy contract - https://etherscan.io/tx/0xc3adf42427bbf4f25026da756a02e47317e11bd6ae6cebe8303b38b72f660370

@KPrasch KPrasch merged commit 5c3ee5b into nucypher:main Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekpierre derekpierre derekpierre approved these changes

@KPrasch KPrasch KPrasch approved these changes

@manumonti manumonti Awaiting requested review from manumonti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cygnusv @KPrasch @derekpierre