Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a linter for the rules #5

Open
8 tasks
nuest opened this issue Oct 9, 2019 · 3 comments
Open
8 tasks

Implement a linter for the rules #5

nuest opened this issue Oct 9, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@nuest
Copy link
Owner

nuest commented Oct 9, 2019

  • check out existing Dockerfile linters - do they solve (part of) the challenges?
  • can they be extended to give warnings for specific behaviour?
  • can they be configured so that rules unfavourable for reproducibility are not used?
  • what kind of tests do they do?
  • what are common rules?

https://github.com/search?q=dockerfile+linter

@nuest
Copy link
Owner Author

nuest commented Dec 9, 2019

@psychemedia has some comments in #33. My reply:

I think using any linter for readability and to avoid stupid mistakes is something we can recommend. A linter will also help with formatting consistency, so that a Dockerfile under version control will be tracked more effectively, i.e., in a more readable way.

Building upon that, we could provide a linter with special rules concerning reproducibility in a scientific context. IMO the policing is thinking too far ahead right now.

@vsoch
Copy link
Collaborator

vsoch commented Dec 9, 2019

I've never used a linter, but I'm definitely interested to follow along here!

nuest added a commit that referenced this issue Dec 9, 2019
@nuest nuest added the after preprint Things to do before publication label Mar 2, 2020
@nuest
Copy link
Owner Author

nuest commented Apr 16, 2020

Looking at the list of linters again, the custom rules of https://github.com/projectatomic/dockerfile_lint could be a starting point for our own linter.

nuest added a commit that referenced this issue Apr 16, 2020
@nuest nuest changed the title Linters Implement a linters for the rules May 8, 2020
@nuest nuest added help wanted Extra attention is needed and removed after preprint Things to do before publication labels May 8, 2020
@nuest nuest changed the title Implement a linters for the rules Implement a linter for the rules May 9, 2020
nuest added a commit that referenced this issue Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants