fix(tools): SetBuildTarget and SetTestPlatform overloads in UnityTasks (

#1232)
nuke-build · Aug 31, 2023 · d8d68cf · d8d68cf
1 parent 0c3e9c3
commit d8d68cf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/source/Nuke.Common/Tools/Unity/UnityProjectSettingsExtensions.cs b/source/Nuke.Common/Tools/Unity/UnityProjectSettingsExtensions.cs
@@ -5,7 +5,6 @@
 using System;
 using System.Linq;
 using JetBrains.Annotations;
-using Nuke.Common.Tooling;
 
 namespace Nuke.Common.Tools.Unity;
 
@@ -15,11 +14,10 @@ public static partial class UnityProjectSettingsExtensions
 
     /// <summary><p><em>Sets <see cref="UnityProjectSettings.BuildTarget"/>.</em></p><p>Allows the selection of an active build target before a project is loaded.</p></summary>
     [Pure]
-    public static UnityProjectSettings SetBuildTarget(this UnityProjectSettings toolSettings, UnityBuildTarget buildTarget)
+    public static T SetBuildTarget<T>(this T toolSettings, UnityBuildTarget buildTarget)
+        where T : UnityProjectSettings
     {
-        toolSettings = toolSettings.NewInstance();
-        toolSettings.BuildTarget = buildTarget.ToString();
-        return toolSettings;
+        return toolSettings.SetBuildTarget(buildTarget.ToString());
     }
 
     #endregion

diff --git a/source/Nuke.Common/Tools/Unity/UnityRunTestsSettingsExtensions.cs b/source/Nuke.Common/Tools/Unity/UnityRunTestsSettingsExtensions.cs
@@ -5,7 +5,6 @@
 using System;
 using System.Linq;
 using JetBrains.Annotations;
-using Nuke.Common.Tooling;
 
 namespace Nuke.Common.Tools.Unity;
 
@@ -18,23 +17,21 @@ public static partial class UnityRunTestsSettingsExtensions
     ///   <p>The platform to run tests on.</p>
     /// </summary>
     [Pure]
-    public static UnityRunTestsSettings SetTestPlatform(this UnityRunTestsSettings toolSettings, UnityTestPlatform testPlatform)
+    public static T SetTestPlatform<T>(this T toolSettings, UnityTestPlatform testPlatform)
+        where T : UnityRunTestsSettings
     {
-        toolSettings = toolSettings.NewInstance();
-        toolSettings.TestPlatform = testPlatform.ToString();
-        return toolSettings;
+        return toolSettings.SetTestPlatform(testPlatform.ToString());
     }
 
     /// <summary>
     ///   <p><em>Sets <see cref="UnityRunTestsSettings.TestPlatform"/></em></p>
     ///   <p>The platform to run tests on.</p>
     /// </summary>
     [Pure]
-    public static UnityRunTestsSettings SetTestPlatform(this UnityRunTestsSettings toolSettings, UnityBuildTarget buildTarget)
+    public static T SetTestPlatform<T>(this T toolSettings, UnityBuildTarget buildTarget)
+        where T : UnityRunTestsSettings
     {
-        toolSettings = toolSettings.NewInstance();
-        toolSettings.TestPlatform = buildTarget.ToString();
-        return toolSettings;
+        return toolSettings.SetTestPlatform(buildTarget.ToString());
     }
 
     #endregion