Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/cache and actions/upload-artifact to v4 #1335

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Feb 18, 2024

GitHub keeps complaining.. actions/checkout@v4 in covered with #1298

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@lahma lahma marked this pull request as ready for review February 18, 2024 09:26
@matkoch
Copy link
Member

matkoch commented Feb 21, 2024

5 pull requests in a row 🙌 all looking good.. merging asap.

@lahma
Copy link
Contributor Author

lahma commented Feb 21, 2024

Don't forget my other two 😉 Been fun trying out different things with NUKE and especially now leaning towards the components when possible.

@matkoch matkoch force-pushed the develop branch 4 times, most recently from 0719711 to 6fe1e3b Compare March 20, 2024 01:24
@matkoch matkoch merged commit 1f2031d into nuke-build:develop Mar 20, 2024
3 of 4 checks passed
@lahma lahma deleted the cache-and-publish-v4 branch March 20, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants