added functionality to edit artist/title for tracks in a playlist #1737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have been working on this for the past few days and seem to have a working solution for #1735 The changes allow users to edit the artist or title field in a playlist by double-clicking it. When double-clicked, the field temporarily converts into an editable textbox, allowing users to make changes which are then saved.
Specifically, I have:
Added extra components for each field, which are wrappers on the existing titleCell and TextCell components. These components handle the conversion to editable textboxes and saving the changes.
Ensured that the implementation does not introduce significant complexity.
Request for Guidance:
Functionality seems to work when i manually test,however when running npm test i fail some of the snapshot tests(@nuclear/app:test). Was wondering if this is due to the additional functionality or if i did something wrong during development.
I would appreciate guidance on what tests to write for this new functionality. Specifically, I am looking for advice on:
The types of tests that would be most valuable (e.g., unit tests, integration tests).
Any edge cases or scenarios that I should be mindful of when writing these tests.
Please let me know if there are any additional details or changes needed before submission.