Auxiliary & Access file download #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbklein
force-pushed
the
deploy/staging
branch
3 times, most recently
from
d5f9769
to
03d3e02
Compare
kdid
force-pushed
the
4546-pdf
branch
2 times, most recently
from
d0a11bf
to
7d9a0b1
Compare
25 tasks
mbklein
approved these changes
May 1, 2024
| return "derivatives/" + prefix + "/" + id; | ||
| } | ||
|
|
||
| function extensionFromMimeType(mimeType) { |
There was a problem hiding this comment.
I think this implementation works fine for now, but I'd be more comfortable with the mime.extension(type) method from the mime-types package. That's not currently a top-level project dependency, but it's already pulled in indirectly by axios, so we wouldn't be adding bloat by making use of it. And it may prevent other issues down the road.
kdid
force-pushed
the
4546-pdf
branch
3 times, most recently
from
8cdadca
to
83ecbf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for "downloading" PDF and ZIP "Auxiliary" files through the
file-sets/id/downloadendpointChanges in this PR
renderingto IIIF manifests containing PDF Aux files: https://iiif.io/api/cookbook/recipe/0046-rendering/get-file-set-downloadhandler to allow downloading .pdf or .zip Auxiliary files302redirect responseget-file-set-downloadhandler to allow "downloading" full size IIIF image for Access/Auxiliary image files through the IIIF serverTo Test