Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add placeholder canvas if representative image is null #209

Merged
merged 1 commit into from
May 15, 2024
Merged

Don't add placeholder canvas if representative image is null #209

merged 1 commit into from
May 15, 2024

Conversation

kdid
Copy link
Contributor

@kdid kdid commented May 15, 2024

  • Images should always have a representative image, but if for some reason they don't, we don't want to return 400: BadRequest. Just don't add the placeholderCanvas property

@kdid kdid force-pushed the 4200-type-error-manifest branch from 43b4f7d to 6364cb7 Compare May 15, 2024 17:54
@kdid kdid requested a review from mathewjordan May 15, 2024 17:57
mathewjordan
mathewjordan approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kdid kdid merged commit f530970 into deploy/staging May 15, 2024
1 check passed
@kdid kdid deleted the 4200-type-error-manifest branch May 15, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewjordan mathewjordan mathewjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdid @mathewjordan